Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drush command to clear the locale status #5311

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

rolfvandekrol
Copy link
Contributor

Updating modules does not automatically clear the locale status. This causes problems in our automatic deployments, because that means the locale:update command will sometimes try to use .po files for older versions of modules.

We use drupal-composer/drupal-l10n to include the correct .po files in our build and don't allow downloading the .po files inside the production container.

When we clear the locale status before running locale:update, it always uses the correct files.

We could potentially add this to our own scripts, but we think this is also useful for other Drush users.

Copy link
Contributor

@Sutharsan Sutharsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I understand the use case and agree that it is beneficial for others. I have objection to add this command.

@Sutharsan Sutharsan enabled auto-merge (rebase) January 31, 2023 14:08
@Sutharsan
Copy link
Contributor

@weitzman I'm fine with adding this to 11.x.

@weitzman weitzman enabled auto-merge (squash) January 31, 2023 15:59
@weitzman weitzman merged commit d468ddc into drush-ops:11.x Jan 31, 2023
@rolfvandekrol rolfvandekrol deleted the feature/locale-clear-status branch April 18, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants