Sanity check service data in legacy service instantiator #5629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…services. Skip any service file that we do not have confidence in.
weitzman
reviewed
Jun 7, 2023
Co-authored-by: Moshe Weitzman <weitzman@tejasa.com>
weitzman
reviewed
Jun 7, 2023
|
|
||
| // We don't support auto-wiring | ||
| if (!empty($serviceFileData['services']['_defaults']['autowire'])) { | ||
| $this->logger->warning(dt('Autowire not supported; skipping @file', ['@file' => $serviceFile])); |
There was a problem hiding this comment.
I think we should downgrade these to info(). They are typically going to be from commandfiles that you dont care about. Its not like user is trying to run a command in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that service data looks reasonable before instantiating any services. Skip any service file that we do not have confidence in.