Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PR template PULL_REQUEST_TEMPLATE.md #6039

Closed
wants to merge 4 commits into from

Conversation

gitressa
Copy link
Contributor

The Issue

How This PR Solves The Issue

Adds a PR template file.

@weitzman
Copy link
Member

This doesnt add much useful over a plan description box. We dont want to encourage the filing of useless issues that bifurcate the conversation.

@weitzman weitzman closed this Jun 17, 2024
@gitressa
Copy link
Contributor Author

I agree that it should not be required to create a corresponding issue for a PR, PR's should be allowed to stand alone. Drush users linking PR's with issues is a common thing though, if you look under the PR's.

I updated the patch in my branch, to clarify that corresponding a issue to a PR is not required, but it's not getting transferred to this PR, so here it is:


name: Pull request
about: For support requests, please use Drupal Answers instead. See https://drupal.stackexchange.com/questions/tagged/drush

Optional: Link pull request and issue, if an issue exists
Drush pull requests don't require an issue, but if an issue exists, you can connect this PR and the issue:

  • Fixes #

Describe the pull request
A clear and concise description of what the pull request does, for example which problem it solves, or feature it adds.

Additional information
Add any other context about the pull request here.

@weitzman
Copy link
Member

If there is an issue, of course it makes sense to link it. I dont think we need to tell people about that authoring features like issue linking, just like we dont tell people about markdown and mentioning people.

@gitressa
Copy link
Contributor Author

All right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PR template, with Fixes ISSUE link
2 participants