Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emm... am I doing this correctly? #62

Closed
Drutol opened this issue Sep 24, 2016 · 31 comments
Closed

Emm... am I doing this correctly? #62

Drutol opened this issue Sep 24, 2016 · 31 comments

Comments

@Drutol
Copy link
Owner

Drutol commented Sep 24, 2016

I've beenworking on countdown till next episode but the more I'm thinking about this the more confused I am...

image
(This is with timezone offset... it must be alright, right?)

I hate timezones btw xd

@Drutol
Copy link
Owner Author

Drutol commented Sep 24, 2016

  • @Kimod : I've (probably) fixed this issue which I was avoiding with days on shows that are no longer airing. ^^

@Kimod
Copy link

Kimod commented Sep 24, 2016

  • This countdown looks good, I'm sure that timezones are hell :/ Huray on solving that issue with days still remaining visible!
  • And sorry if unrelated, but could you somehow show on airing shows that new episode is available? I don't really know how you could make it work, but I believe in you ^^ (bot Roboragi somehow made it work https://www.reddit.com/r/Animesuggest/comments/547t2d/visually_stunning_anime/d7zv1gl and is also on github (click on source on that comment) , so maybe you could inspire yourself? :3)
  • And also I saw that you said that rewatching isn't possible, but the app I use on android somehow made it work, the only thing that is API limitation is pulling the Rewatched times thing - http://imgur.com/a/XLFu4 (sorry if those images were useles and AFAIK the app isn't open source)

@Drutol
Copy link
Owner Author

Drutol commented Sep 24, 2016

  • They sure are...
  • Maybe some day... this is so freaking tricky due to obtaining data from html... aaagh my head hurts! I love how every comment in this bot code states that MAL's API is pure shit though. From what I managed to find in this code, this feature is based on yet another API.
  • To be honest I have no clue how rewatching works on mal and I have never used it. All I know is that somebody said it's bugged on MAL API club and I decided to do notifications instead. Explain me how this exactly work and I may do this ^^

@Kimod
Copy link

Kimod commented Sep 24, 2016

If someone is rewatching something, it will set 'my_rewatching' to 1 - http://puu.sh/rmlOd.png and the amount of rewatched episodes is 'my_watched_episodes' (so I guess nothing new) and notice the 'my_status' is set to 2, which means completed (at least I think), so you will have to somehow get it to watching tab in your app. To rewatch something you have to click on 'Re-waching' checkbox - http://puu.sh/rmm4L.png in 'edit' and as I said, the only thing that is bugged is that you can't obtain the 'Total Times Re-watched Series' from the API, but you can send it... (at least from android app I use). I hope I helped somehow ^^

@Drutol
Copy link
Owner Author

Drutol commented Sep 24, 2016

God dammit... okay okay I'll look into this thing.

So... this glorified re-watching thing is just mere flag? I thought that there is separate episode count.
Brb

@Drutol
Copy link
Owner Author

Drutol commented Sep 24, 2016

image

No comment

@Drutol
Copy link
Owner Author

Drutol commented Sep 24, 2016

Ok, now I have to make UI for this and we are all set ^^

image

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

🎉
image

Now I'm preparing to push this build to the store... I still have to fix desktop forums ;d

@Kimod
Copy link

Kimod commented Sep 25, 2016

I think you should have 0 times rewatched in that list too, so you can reset it from the app... Other than that, it looks pretty cool ^^ And how does it work with My Start and My End? Does it overwrite the date before, or will it set it only if you haven't got any date before? Or is it purely coincidence? (I'm asking since you have My Start set to today)

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

I did set watching in the meantime and I did not have start date previously so it set it for me,

It does not change start/end dates nor current status. All what is changed is number of watched eps and rewatching flag.

I'll send you test version in a few hours ^^

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

calendar countdown, rewtaching, notifications, better forums, major hummingbird fixes

x64:
https://1drv.ms/u/s!Am1xQK-HVf_IkslM3MwSUKplcMnjTg
ARM:
https://1drv.ms/u/s!Am1xQK-HVf_IkslLTVOOBHJy_Oh2Hw

@Kimod
Copy link

Kimod commented Sep 25, 2016

Rewatching doesn't work properly, I was really confused why it didn't work, because it seemed like it worked first time (it didn't work, it just seemed like it worked) There are a couple of problems

So that means it doesn't send and read the rewatching flag properly?
Maybe those two are related/wrong/doesn't work just for me, just my observation ^^

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

Hmm I think I know where's the mistake... How about the rest?

@Kimod
Copy link

Kimod commented Sep 25, 2016

Everything else works, how exactly are the notifications working? I have one unread notification that I kept unread, will the app eventually pull it? I didn't have the version with just notifications, so it may just take a little time, especially with the crappy UWP windows 10 notifications (I even have problems with Outlook app......)
If you want some bugs here are a few

  • Profile "RayAdha"'s favorite anime isn't high enough, because the first anime cover picture "Doraemon (1979)" isn't high enough - http://puu.sh/rnekI.jpg
    • ✔️ Fixed
  • If favorite people doesn't have picture, they aren't fully scretched - http://puu.sh/rnemd.jpg
    • ✔️ Fixed
  • This is still a thing - When I click on pinned topic and then go back with that back button, it goes through an empty list - http://puu.sh/qwuqn.gif
    • 🌠 How about repinning this? I think that I have fixe dthis at some point... (works for me)
  • If you click on a person with picture and then on person without picture, the picture will remain visible - http://puu.sh/rneRq.gif
    • ✔️ Fixed
  • I was wondering if you did something about this, you didn't xD - http://puu.sh/rnetA.jpg (time till next ep and show's season both enabled)
    • ✔️ Fixed, did your really thought that I would remember about this? xd

✔️ Fixed rewatching

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

Yeah, notifications or rather BG tasks that fetch them are one big unknown. It did fork for me a few times though... You can always trigger them in settings tab :)

@Kimod
Copy link

Kimod commented Sep 25, 2016

  • Oh, didn't know about that button. Hmm, when I click on it, it will crash - http://puu.sh/rnpUc.gif
  • I'm special snowflake, stuff that isn't happening to you is happening to me :/ - http://puu.sh/rnq8n.gif (maybe it's only if I pin post that I searched for?)
    • ✔️ Correct, it was search
  • If you search for something in forums, there isn't date next to it - http://puu.sh/rnqL6.png
    • ✔️ Fixed

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

Can you send me this script from #58 ?

@Kimod
Copy link

Kimod commented Sep 25, 2016

this? (edit comment to see it :3)

<script> window.MAL.notification = {"items":[{"id":"12947861","typeIdentifier":"related_anime_add","categoryName":"New Related Anime","createdAt":1474566833,"createdAtForDisplay":"Sep 22, 7:53 PM","isRead":false,"url":"https:\/\/myanimelist.net\/anime\/34103\/Danganronpa_3__The_End_of_Kibougamine_Gakuen_-_Kibou-hen","isDeleted":false,"anime":{"title":"Danganronpa 3: The End of Kibougamine Gakuen - Kibou-hen","mediaType":"Special"}}],"historyItems":[]}; window.MAL.notification.hideEmpty = false; window.MAL.notification.templates = {"main":"
<\/notification-list>\n\n
\n <\/div>\n\n <\/section>","list":"
\n
\n
\n \n <\/i>Mark All as Read\n <\/span>\n <\/div>\n

New Notifications<\/h3>\n <\/div>\n
\n
\n <\/div>\n

History<\/h3>\n <\/div>\n\n
    \n
  1. \n <\/a>\n
    \n <\/component>\n
    (deleted)<\/div>\n ${item.createdAtForDisplay}<\/span>\n \n <\/i>\n <\/i>\n <\/span>\n <\/div>\n <\/li>\n
  2. \n
    \n

    No ${isHistory ? \"history\" : \"notifications\"}.<\/p>\n <\/div>\n <\/li>\n <\/ol>\n <\/div>\n ","itemFriendRequest":"

    \n
    \n ${item.friendName}<\/a>\n sent you a friend request${item.message.length ? \":\" : \".\"}\n ${item.message}<\/q>\n <\/div>\n

    \n \n Accept<\/span>Deny<\/span> <\/span>\n \n Accepted<\/span>\n <\/span>\n <\/p>\n <\/div>\n ","itemFriendRequestAccept":"

    \n ${item.friendName}<\/a>\n accepted your friend request.\n <\/div>\n ","itemFriendRequestDeny":"
    \n ${item.friendName}<\/a>\n denied your friend request.\n <\/div>\n ","itemProfileComment":"
    \n ${item.commentUserName}<\/a>\n posted a comment on your profile${item.text.length ? \":\" : \".\"}\n ${item.text}<\/q>\n <\/div>\n ","itemForumQuote":"
    \n ${item.quoteUserName}<\/a>\n quoted your post in the\n ${item.topicTitle}<\/a>\n topic.\n <\/div>\n ","itemBlogComment":"
    \n ${item.commentUserName}<\/a>\n posted a comment on your blog.\n <\/div>\n ","itemWatchedTopicMessage":"
    \n A forum reply was posted on your watched topic\n ${item.topicTitle}<\/a>.\n <\/div>\n ","itemClubMassMessageInForum":"
    \n ${item.sharedUserName}<\/a> shared the discussion\n ${item.topicTitle}<\/a>\n in ${item.clubName}<\/a>.\n <\/div>\n ","itemUserMentionInForumMessage":"
    \n ${item.senderName}<\/a>\n has mentioned your name in the\n ${item.pageTitle}<\/a>\n <\/span>.\n <\/div>\n ","itemOnAir":"
    \n The anime you plan to watch began airing on ${item.date}:\n \n ${anime.title}<\/a>, <\/template>\n <\/template>\n <\/div>\n ","itemRelatedAnimeAdd":"
    \n ${item.anime.title}<\/a> (${item.anime.mediaType}) has just been added to the database.\n <\/div>\n ","itemPaymentStripe":"
    \n ${item.planName}<\/i> has been suspended, because the payment for your subscription was unable to be processed.\n <\/div>\n "}; </script>

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

Sneaky sneaky

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

I guess I'll have to send you debug build because this input data works for me...

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

💥 CRASH THIS AS MUCH AS YOU CAN 💥

https://1drv.ms/u/s!Am1xQK-HVf_Ikspog4uM-7pSc0qgXA

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

Caught one!

image

@Kimod
Copy link

Kimod commented Sep 25, 2016

༼ つ ◕..◕ ༽つ Crashes happened ༼ つ ◕..◕ ༽つ

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

It seems that messages are crashing, do you have any? Try disabling them in settings and try again xd

@Kimod
Copy link

Kimod commented Sep 25, 2016

Yup, it works without messages checked - http://puu.sh/rnw76.gif , I don't think I have any messages - http://puu.sh/rnwfm.png

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

Yeah, I was throwing my own exception which I forgot to catch, and it went free..... 🎈

Feel free to do nasty things with this build, it will tell me all about how you've been treating him.

@Kimod
Copy link

Kimod commented Sep 25, 2016

So will you try to solve this crash that just happened? I quickly clicked on friend's friends - http://puu.sh/rnx5O.gif crashed it 2 times (usually it happens a lot faster, the first time it crashed after 3 profiles)

@Drutol
Copy link
Owner Author

Drutol commented Sep 25, 2016

image

Bam, and I know what's happening now. Crash this thing more ^^

@Kimod
Copy link

Kimod commented Sep 25, 2016

  • If you click on History, Load characters in anime details, or Calendar (that wasn't previously builded) without internet connection, it will crash.
  • This isn't a crash - how is this possible without internet connection? I loaded them before with internet, the scores are actually stored but they for some reason won't be displayed - http://puu.sh/rnzQR.gif
    • 🌠 ✔️ Fixed My app transcends the thing you call the Internet and creates it's own! It's a feature!
  • Ugh how do I make the notification to not notify me again? Do I have to go to the website and mark it as Read?
    • 🌠 Comment bellow
  • Progress bar during Load all details will be stuck if you cancel it and then load things in another list - http://puu.sh/rnBIg.gif
    • 🌠 No clue why... everything with the data itself is okay... I'll leave this for the time being

I didn't found any more ways to crash your app, it went through a lot of nasty things :3

@Drutol
Copy link
Owner Author

Drutol commented Sep 26, 2016

Read notifications are stored in cross-device storage and they only appear once for me. Maybe it's something with debug version itself.

@Drutol
Copy link
Owner Author

Drutol commented Sep 26, 2016

27.09.2016 v5.0.19 & v5.0.18.0

Added notifications!
New store logo!
Added calendar episode countdown!
Added re-watching support.
Improved forums.
Major Hummingbird fixes.
Various tweaks and fixes.

@Drutol Drutol closed this as completed Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants