chore(Dockerfile): Simplify testssl user creation
#2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create `testssl` user (_and group_) with no password (`-D`) and default their shell to bash (`-s`): - A group will implicitly be created with the same value as the user. `addgroup testssl` and `-G testssl` are not needed. - Gecos data (`-g "testssl user"`) doesn't appear relevant to the project to be required? The default gecos value (`Linux User,,,`) should be fine.
|
Thanks! |
polarathene
commented
Feb 7, 2023
| ln -s /home/testssl/testssl.sh /usr/local/bin/ | ||
| adduser -D -s /bin/bash testssl && \ | ||
| ln -s /home/testssl/testssl.sh /usr/local/bin/ && \ | ||
| mkdir -m 755 -p /home/testssl/etc /home/testssl/bin |
There was a problem hiding this comment.
Just a heads up @drwetter when this PR was raised, I think it was separate from the mkdir change, which you had merged earlier.
When you updated the branch here before merging, it looks like it didn't diff well, and accidentally brought back the mkdir line? (the previous PR change is actually missing from the files history now).
You may want to remove the line again.
There was a problem hiding this comment.
Both commits are in the 3.1dev branch history though 🤷♂️
drwetter
added a commit
that referenced
this pull request
Feb 7, 2023
|
Thanks, PR pending/merged I manually had to resolve the conflict and I just removed w/o thinking what github labeled as conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2305 (specifically this commit)
Create a
testssluser (and group) with no password (-D) and default their shell to bash (-s):addgroup testssland-G testsslare not needed.-g "testssl user") doesn't appear relevant to the project to be required? The default gecos value (Linux User,,,) should be fine.