Separate outputs for CommonJS and ESM when building openapi-typescrip…

[darwish]

…t-helpers

Changes

Fixes #1478

Creates separate output directories for CommonJS and ESM for the output of openapi-typescript-helpers.

How to Review

1. Run pnpm build
2. Check that both packages/openapi-typescript-helpers/dist/ and packages/openapi-typescript-helpers/dist/cjs/ contain an index.ts and an index.d.ts file.

Checklist

• Unit tests updated
• docs/ updated (if necessary)
• pnpm run update:examples run (only applicable for openapi-typescript)

[changeset-bot]

🦋 Changeset detected

Latest commit: 935d4e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
openapi-fetch	Patch
openapi-typescript-helpers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[drwpow]

Nice fix! Thank you!

[drwpow]

Hm the failing tests might be from a race condition while building openapi-fetch and openapi-typescript-helpers. It seems that because openapi-typescript-helpers now requires a build step to work that it didn’t need before, it has to happen before openapi-fetch.

As a workaround, in the root, I’d recommend doing something like:

  "scripts": {
    "build": "run-p -s build:*",
    "build:openapi-typescript": "cd packages/openapi-typescript && pnpm run build",
-   "build:openapi-typescript-helpers": "cd packages/openapi-typescript-helpers && pnpm run build",
-   "build:openapi-fetch": "cd packages/openapi-fetch && pnpm run build",
+   "build:openapi-fetch": "cd packages/openapi-typescript-helpers && pnpm run build && cd ../openapi-fetch && pnpm run build"

The TS helpers build is basically instant/trivial. And this keeps openapi-fetch and openapi-typescript built in parallel, which while both are quick, still makes a noticeable difference in CI runs

[darwish]

Thanks, I've applied your fix.

[drwpow]

Hm something else seems to be going on. Will take a closer look later

[drwpow]

This is working for me locally, and seems to just be a weird CI issue. I’ll merge this, then poke at it separately.

[drwpow]

Oh I figured it out—it was a CI thing. It was just in the test runs, each individual package was building itself but not others (i.e. we updated it in the wrong place, the building of openapi-typescript-helpers needed to happen inside openapi-fetch’s package.json itself).

But really it’s just a flimsy setup; I’ll make some changes that make that better (also we shouldn’t have a prepare step on openapi-fetch itself)