refactor(openapi-fetch): simplify createClient types #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4765658 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks! I’m in favor of cleanup like this—looks much better. However, something is off, because the tests are failing (the |
wydengyre
force-pushed
the
refactor-simplify-createclient-types
branch
from
e2f64f3
to
4765658
Compare
wydengyre
changed the title
|
@drwpow tests are passing when I run locally now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a ClientMethod utility type to simplify the object definition of the return type of createClient.
How to Review
This is a refactor adding a utility type and cleaning up some code. All tests should pass and no dependencies should be affected. Have a look at it and see if it seems more readable.
Checklist
None of these apply to this change. It should not affect tests, not affect docs, and not touch the examples.
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)