Removes Maybe monad

dry-python · Feb 4, 2019 · 2e6decb · 2e6decb
1 parent edb8ae2
commit 2e6decb
Show file tree

Hide file tree

Showing 15 changed files with 5 additions and 519 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,7 @@ We follow Semantic Versions since the `0.1.0` release.
 - Renames `ebind` to `rescue`
 - Renames `efmap` to `fix`
 - Renames `Monad` to `Container`
+- Removes `Maybe` monad, since typing does not have `NonNullable` type
 
 
 ## Version 0.3.1

diff --git a/docs/index.rst b/docs/index.rst
@@ -17,7 +17,6 @@ Contents
   :caption: Userguide
 
   pages/container.rst
-  pages/maybe.rst
   pages/result.rst
   pages/functions.rst
 

diff --git a/docs/pages/functions.rst b/docs/pages/functions.rst
@@ -10,19 +10,17 @@ is_successful
 :func:`is_succesful <returns.functions.is_successful>` is used to
 tell whether or not your result is a success.
 We treat only treat types that does not throw as a successful ones,
-basically: :class:`Success <returns.result.Success>`
-and :class:`Some <returns.maybe.Some>`.
+basically: :class:`Success <returns.result.Success>`.
 
 .. code:: python
 
   from returns.result import Success, Failure
   from returns.functions import is_successful
-  from returns.maybe import Some, Nothing
 
-  is_successful(Some(1)) and is_successful(Success(1))
+  is_successful(Success(1))
   # => True
 
-  is_successful(Nothing) or is_successful(Failure('text'))
+  is_successful(Failure('text'))
   # => False
 
 .. _pipeline:

diff --git a/docs/pages/maybe.rst b/docs/pages/maybe.rst
diff --git a/returns/maybe.py b/returns/maybe.py
diff --git a/returns/maybe.pyi b/returns/maybe.pyi
diff --git a/setup.cfg b/setup.cfg
@@ -31,7 +31,7 @@ per-file-ignores =
   **/*.pyi: D100, D401, X100
   **/*.py: D100, D401, X100
   # Disable some `.pyi` specific warings:
-  **/*.pyi: D101, D102, D103, D107, Z214, Z444, Z452
+  **/*.pyi: D101, D102, D103, D107, Z444, Z452
   # TODO: fix check and remove it from ignores
   **/*.py: Z454
   **/*.pyi: Z454

diff --git a/tests/test_functions/test_is_successful.py b/tests/test_functions/test_is_successful.py
@@ -3,14 +3,11 @@
 import pytest
 
 from returns.functions import is_successful
-from returns.maybe import Nothing, Some
 from returns.result import Failure, Success
 
 
 @pytest.mark.parametrize('container, correct_result', [
-    (Some, True),
     (Success, True),
-    (Nothing, False),
     (Failure, False),
 ])
 def test_is_successful(container, correct_result):