You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now we expect dependency names to use dots as delimiter characters, e.g. "my_app.foo.bar". We split the name up by the dots and use the last portion as the local name for the dependency (its instance variable and accessor method name).
We should expand on this so dependencies with other separator characters or otherwise invalid characters are handled appropriately.
We've had some discussion on this over in #23 (comment). My feeling is that something like this would be a reasonable approach:
I think it'd might be better if we just had a regex of invalid variable-name characters, split the container identifier on that regex, and then just use the last segment as the local variable name. What do you think? This seems fair to me, especially now that people can explicitly provide their own aliases for their injected dependencies too.
The text was updated successfully, but these errors were encountered:
Right now we expect dependency names to use dots as delimiter characters, e.g.
"my_app.foo.bar"
. We split the name up by the dots and use the last portion as the local name for the dependency (its instance variable and accessor method name).We should expand on this so dependencies with other separator characters or otherwise invalid characters are handled appropriately.
We've had some discussion on this over in #23 (comment). My feeling is that something like this would be a reasonable approach:
The text was updated successfully, but these errors were encountered: