Change what constructors are considered pass-through #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash-gordon
force-pushed
the
fix-injection-with-delegation
branch
2 times, most recently
from
7be3d7c
to
d6ecd0d
Compare
flash-gordon
force-pushed
the
fix-injection-with-delegation
branch
from
d6ecd0d
to
8cebaec
Compare
|
@flash-gordon yes this works perfectly 🎉 thank you |
|
great, let's get this fixed then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #77. Using
...for calling super methods is not the only way this syntax works, it also works for delegation. From dry-auto_inject's POV there's no way to figure out what's going to happen after delegation, it may work, it may not.I removed the old spec (it didn't work btw: it didn't start falling after the change) and changed what can be considered as a pass-through constructor.
@parndt please please confirm this works for you