Delegate all NestedConfiguration to its own class to fix reset_config

[GustavoCaso]

Regarding the commit fd8ccfe where it exposes that reset_config was not working for nested configurations.

@AMHOL I have followed what we talked yesterday, and even it since a little by hacky as well, all the logic for nested configurations is encapsulated in its own class.

The PR still in WIP because I wanted to know if you like this approach if so I will add a test for everything that is new and remove the WIP label so we can merge it, if not I will keep looking for an alternative.

@AMHOL thanks for the help.

[AMHOL]

Couple of questions but looks good, nice one @GustavoCaso 👍

[AMHOL]

Never seen this defined as a private method before, any implications?

[GustavoCaso]

If I'm honest no idea, but I can move outside of private

[AMHOL]

It's fine as-is, I guess method missing will only be called privately anyway, just never thought of it before 😄

[AMHOL]

Perhaps the above two lines can be moved to the new NestedConfig class too, an this could just become:

::Dry::Configurable::NestedConfig.new(&block)

[GustavoCaso]

But we still have to pass the config_klassinstance to ::Dry::Configurable::NestedConfig.

[AMHOL]

Could just update ::Dry::Configurable::NestedConfig.new to:

module Dry
  module Configurable
    # @private
    class NestedConfig
      def initialize(&block)
        klass = ::Class.new { extend ::Dry::Configurable }
        klass.instance_eval(&block)
        @klass = klass
      end
      # ...

Then it fully encapsulates the creation of nested config

[GustavoCaso]

Awesome thats great I will update the code, and the missing test so we can move forward

[GustavoCaso]

@AMHOL, since is a NestedConfig doesn't have much to test in my opinion, and there is the complete integration test, for the configurable Module we could ship this.

What do you think?

[AMHOL]

@GustavoCaso seems fair to me, thanks for implementing this 👍

[AMHOL]

@GustavoCaso this is now released under 0.6.1