Evaluate setting immediately if input defined #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timriley
force-pushed
the
evaluate-setting-if-input-defined
branch
from
39ae458
to
4b603a7
Compare
timriley
requested review from
solnic and
flash-gordon
and removed request for
solnic
timriley
force-pushed
the
evaluate-setting-if-input-defined
branch
from
4b603a7
to
679d2d7
Compare
solnic
approved these changes
Jun 22, 2020
esparta
added a commit
to esparta/dry-configurable
that referenced
this pull request
Aug 4, 2020
There's an corner case when a configuration should not be memoized
when using pre-processor values:
MyMonitor = Class.new
class Producer
include Dry::Configurable
setting(:monitor, false) { |monitor| monitor || MyMonitor.new }
end
p01 = Producer.new
p02 = Producer.new
raise 'Not memoized allowed' if p01.config.monitor.object_id == p01.config.monitor.object_id
This behavior was introduced on Dry::Config 0.11.6, on PR dry-rb#95
Fixed dry-rb#96
Notes: I'm modifying the tests for Dry::Config::Setting because the test
was interfeiring with the behavior when introduce a constructor which
happend to be exactly the issue when using the setting method.
esparta
added a commit
to esparta/dry-configurable
that referenced
this pull request
Aug 4, 2020
There's an corner case when a configuration should not be memoized
when using pre-processor values:
MyMonitor = Class.new
class Producer
include Dry::Configurable
setting(:monitor, false) { |monitor| monitor || MyMonitor.new }
end
p01 = Producer.new
p02 = Producer.new
raise 'Not memoized allowed' if p01.config.monitor.object_id == p01.config.monitor.object_id
This behavior was introduced on Dry::Config 0.11.6, on PR dry-rb#95
Fixed dry-rb#96
Notes: I'm modifying the tests for Dry::Config::Setting because the test
was interfeiring with the behavior when introduce a constructor which
happend to be exactly the issue when using the setting method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for immediate feedback to be provided to users if an input is provided for a setting that has a constructor designed to raise errors when invalid input is provided.
I've checked this change against dry-{schema,validation,system} and they're all still green.