Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to use latest dry-configurable and dry-system #83

Merged
merged 2 commits into from Jun 12, 2021

Conversation

timriley
Copy link
Member

This starts with a minor change to how we configure the auto_registrar for the container class in the system extension.

It also updates the custom AutoRegistrar implementation to match the new behaviour released in 0.19.0.

This means we don't need to worry about updating to the latest dry-configurable `setting` API, which requires the `default:` keyword arg for default values.
@timriley timriley requested a review from solnic as a code owner May 24, 2021 12:18
@timriley timriley force-pushed the update-for-latest-dry-configurable-dry-system branch from ae06f59 to 792e065 Compare May 24, 2021 12:22
@timriley timriley force-pushed the update-for-latest-dry-configurable-dry-system branch from 792e065 to f3a5b2f Compare May 24, 2021 12:55
@flash-gordon flash-gordon merged commit 8b1b6da into master Jun 12, 2021
@flash-gordon flash-gordon deleted the update-for-latest-dry-configurable-dry-system branch June 12, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants