Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singularize method return 'bonuses' as 'bonuse' #33

Closed
D5ky opened this issue Dec 17, 2020 · 1 comment · Fixed by #38
Closed

singularize method return 'bonuses' as 'bonuse' #33

D5ky opened this issue Dec 17, 2020 · 1 comment · Fixed by #38
Labels
bug

Comments

@D5ky
Copy link

D5ky commented Dec 17, 2020 •
edited
Loading

Describe the bug
Dry::Inflector.new.singularize('bonuses') => "bonuse"

To Reproduce

Call Dry::Inflector.new.singularize('bonuses')

Expected behavior

Dry::Inflector.new.singularize('bonuses') => 'bonus'

Your environment

  • Affects my production application: NO
  • Ruby version: ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-darwin19]
  • OS: macOS Catalina 10.15.7
@D5ky D5ky added the bug label Dec 17, 2020
@cllns
Copy link
Member

cllns commented Jun 14, 2021

👍 Similar words which also fail this way:

  • Dry::Inflector.new.singularize('geniuses') # => 'geniuse'
  • Dry::Inflector.new.singularize('walruses') # => 'walruses'

cllns added a commit to cllns/dry-inflector that referenced this issue Jun 14, 2021
@cllns
Fix singularizing -us suffix
444f1ad 
Closes dry-rb#33
cllns added a commit to cllns/dry-inflector that referenced this issue Jun 14, 2021
@cllns
Fix singularizing -us suffix
bd41377 
Closes dry-rb#33
@cllns cllns mentioned this issue Jun 14, 2021
Merged
solnic added a commit that referenced this issue Jun 18, 2021
@solnic
Merge pull request #38 from cllns/improve-singularizing-suffix-us
e99ab9c 
[changelog]

version: unreleased
fixed: "Fix singularizing -us suffix (issue #33 via #38) (@cllns)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix singularizing -us suffix cllns/dry-inflector
2 participants
@cllns @D5ky