This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Defer accessing config until after user-provided block is evaluated #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible for users to e.g. use dry-system plugins that add new settings, which otherwise raises a Dry::Configurable::AlreadyDefinedConfig if any config has been accessed previously
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| default_options = { | ||
| root: ::Rails.root, | ||
| system_dir: ::Rails.root.join('config/system'), |
There was a problem hiding this comment.
Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
Yes but we need a test that covers this change too. Reproducing your use case in a spec would be enough. |
timriley
force-pushed
the
defer-accessing-config
branch
from
c768d7a
to
0414073
Compare
|
@solnic OK, so short of a major overhaul of the whole testing infrastructure here (like we just discussed, to support testing specific aspects of this Railtie's behaviour in complete isolation), are you fine with the test I've just added now? It demonstrates the behaviour that this change supports. And that test is red on master, green here. |
solnic
approved these changes
Sep 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for users to e.g. use dry-system plugins that add new settings, which otherwise raises a
Dry::Configurable::AlreadyDefinedConfigerror if any config has been accessed previously.This would be fixed anyway once we address dry-rb/dry-configurable#70, but that's a larger piece of work, and I'd like to make dry-system-rails more flexible in the meantime.
The reason I actually needed this is because I wanted to use the dry-system
settingscomponent, which requiresuse :envto be added within theDry::System::Rails.container do ... endblock.use :envadds a new setting, so we need to make sure this block is evaluated as early as possible to avoid that error above.@solnic Does this look OK to you?