Attempt to lazy-load component when container is asked for key?
#120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -641,17 +666,19 @@ def inherited(klass) | |||
| private | |||
|
|
|||
| # @api private | |||
| def load_local_component(component, default_namespace_fallback = false) | |||
| def load_local_component(component, default_namespace_fallback = false, &block) | |||
There was a problem hiding this comment.
Metrics/AbcSize: Assignment Branch Condition size for load_local_component is too high. [22.8/20]
Metrics/PerceivedComplexity: Perceived complexity for load_local_component is too high. [8/7]
| @@ -593,8 +618,8 @@ def require_path(path) | |||
| end | |||
|
|
|||
| # @api private | |||
| def load_component(key) | |||
| return self if key?(key) | |||
| def load_component(key, &block) | |||
There was a problem hiding this comment.
Metrics/PerceivedComplexity: Perceived complexity for load_component is too high. [8/7]
|
|
||
| gemspec | ||
|
|
||
| gem 'bootsnap' | ||
| gem 'dry-monitor' | ||
| gem 'dry-container', github: 'dry-container' |
There was a problem hiding this comment.
Bundler/OrderedGems: Gems should be sorted in an alphabetical order within their section of the Gemfile. Gem dry-container should appear before dry-monitor.
|
I forgot to mention, it resolves #109 |
This also adds `Container.registered?` which acts as `key?` used to. Besides it, `Container.resove` not takes an optional block to make this interface constistent with dry-container
flash-gordon
force-pushed
the
lazy-loading-on-key-quering
branch
from
6d65469
to
fca4a64
Compare
solnic
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds
Container.registered?which acts askey?used to.Besides it,
Container.resolvenot takes an optional block to make this interface consistent with dry-container.