Renamed setting dsl method key to setting #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
reviewed
Jul 19, 2021
| schema[name] = type | ||
| end | ||
| alias :key :setting |
There was a problem hiding this comment.
There's actually a deprecate macro in Deprecations extension that you could use here https://github.com/dry-rb/dry-core/blob/master/lib/dry/core/deprecations.rb#L152-L157
There was a problem hiding this comment.
Thanks for your hint!
Since the DSL class is inheriting from BasicObject and is not including any Dry module I don't have access to the deprecate call. Can you point me to a case where there is a similar case so I can take a look on how to do this?
There was a problem hiding this comment.
Check out
dry-system/lib/dry/system/container.rb
Line 98 in 176ead2
Extend from Dry:Core:Deprecations and then use deprecate instead of alias.
Best regards ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@timriley mentioned in the ticket 166 that the setting DSL method key should be renamed to setting, which is done in this pr