Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compatibility fixes to support a future dry-configurable 0.13.0 release (for 0.19 series for releases) #186

Merged
merged 2 commits into from Aug 23, 2021
Merged

Make compatibility fixes to support a future dry-configurable 0.13.0 release (for 0.19 series for releases) #186

merged 2 commits into from Aug 23, 2021

Commits on Aug 21, 2021

  1. Improve argument forwarding for setting override 

    While we still have this override method in place, we need to have it work for both current and upcoming versions of dry-configurable. Using ruby2_keywords for this ensures this works even when we're passing "real" keyword arguments for different params signatures in Ruby 3.0 and beyond.
    @timriley
    timriley committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    d814ce3 View commit details
    Browse the repository at this point in the history

  2. Improve compatibility of setting default 

    Provide an explicit hash literal for the default value (i.e. by adding curly braces) rather than depending on Ruby's implicit "convert keyword arguments to a hash" behavior, which will not work when the dry-configurable `setting` method changes to accept proper keyword arguments in a future release.
    @timriley
    timriley committed Aug 21, 2021
    Configuration menu
    Copy the full SHA
    3222278 View commit details
    Browse the repository at this point in the history