-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename it to dry-types! #21
Comments
I called it like that because I use it to work with data. It is also a nice And thanks for feedback! I understand why it looked ugly to you. It's been ps. Me playing with Haskell definitely influenced me in some way but it
|
I've been thinking about this and currently leaning towards what you suggested. |
|
The project name |
I'd go with module Dry
module Types
module Type
...
...
end
end
end The name of the library should reflect it's usage. Or be something creative/abstract. But now it's misleading. Well of course only until you read the README:-) Type is like Category, Group, ... Perhaps it's to generic?
|
@mrbongiolo public interface for defining types will not expose this class to you (not done yet) so I guess it's not such a big deal after all @pascalbetz I agree, I've thought about this and I like the idea of renaming to Thanks for feedback! |
why not: BTW, we would still declare an app module Types to be used with it? Or is it also changing? |
Well, if you're brave enough, you could try to setup types globally, passing the If talking seriously, I don't see any reason to change this. And even more, I wish there is a way to terraform multiple type spaces not just the global one. Why it's good? For now, |
@marshall-lee you can define types on any namespace you want via FWIW I want dry-data (dry-types!) to be easily usable in libraries too, in fact I already started using it in rom-sql where custom SQL-types are being defined on top of the built-in ones. So this will be one of the use cases for this gem and I definitely want to make sure it has nice APIs to support it. |
Can I suggest recreating the https://github.com/dry-rb/dry-data repo so that it redirects to the new URL, or contains a simple README noting that the repo has been renamed and moved? There are a lot of links around (including on @solnic's own blog ;) ) that still point to "dry-data" and now those links 404; it's not clear to a newcomer what happened to that repo (i.e. that it was just renamed and not e.g. deleted altogether or broken up into smaller gems) |
Given that a google search for dry-data returns this dry-types repo as the first result, I don't think this is really a problem. I'm pretty sure GitHub automatically handle redirects for some period of time after a rename, which is probably why this happened. |
I'll update my blog posts with some info about the rename. On 19 October 2016 at 04:47:09, Tim Riley (notifications@github.com) wrote:
|
Hello, @solnic!
I revisited your gem again and now it looks better to me. In fact, I find it somehow ideal because it gives maximum flexibility and the API is pretty good. I cannot believe because the first time I found
dry-data
very ugly.So the last thing that bothers me is a name. What's wrong with it? Is it a reference to Haskell
data
keyword or what? If so then algebraic data types (structs and sum types in your terms) are not a whole picture.dry-data
works not only with them but with primitive types too. If it's not a reference todata
keyword then what it is? It looks thatdry-data
is not about data but types. Do you agree with me or maybe I'm missing something?The text was updated successfully, but these errors were encountered: