Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible performance issue #52

Closed
gogainda opened this issue Jan 21, 2016 · 5 comments
Closed

Possible performance issue #52

gogainda opened this issue Jan 21, 2016 · 5 comments

Comments

@gogainda
Copy link

On this line was used .any? method which is slow especially when used with big lists. More info and measures could be found here

@solnic
Copy link
Member

solnic commented Jan 21, 2016

Thanks for pointing this out, you're right. I'll be fine-tuning things at some point in the near future.

@gogainda
Copy link
Author

I found this tool useful, try it https://github.com/DamirSvrtan/fasterer

solnic added a commit that referenced this issue Jan 21, 2016
solnic added a commit that referenced this issue Jan 21, 2016
@backus
Copy link
Contributor

backus commented Jan 21, 2016

I found this tool useful, try it https://github.com/DamirSvrtan/fasterer

If you add rubocop to the build too the latest version has a lot of performance cops that might help

@solnic
Copy link
Member

solnic commented Jan 21, 2016

ugh, looks like I referenced incorrect issue in these commits...anyhow, thanks for suggestions, I'm familiar with fasterer. Rubocop is being used on codeclimate, it's nicer to have it there.

@solnic
Copy link
Member

solnic commented Mar 7, 2016

This line is gone, so I'm gonna close this one :)

@solnic solnic closed this as completed Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants