Add request to max_per_window method #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreekingDean
reviewed
Feb 3, 2017
README.md
Outdated
| @@ -132,6 +132,27 @@ significantly more complex than what we've provided for, you can also define | |||
| entirely new kinds of throttling strategies by subclassing the | |||
| `Rack::Throttle::Limiter` base class directly. | |||
|
|
|||
| ### Example | |||
|
|
|||
| Customize the max\_per\_second to be different depending on the request's method. | |||
There was a problem hiding this comment.
(nit) Can you change:
max\_per\_second
to
`max_per_second`
|
Just running some benchmarks to make sure that we don't add too much time to each request :) |
|
Looks good to me. I'm going to merge this later today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would enable to override the max_per_<period> method with something request specific.
E.g. check request.request_method to allow 100 GET but only 10 POST requests. (see tests)