Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary dependency on 5.10 #4

Closed
Leont opened this issue May 23, 2015 · 1 comment
Closed

Unnecessary dependency on 5.10 #4

Leont opened this issue May 23, 2015 · 1 comment
Assignees
@drzigman
Milestone
v0.3.0

Comments

@Leont
Copy link

Leont commented May 23, 2015

This dist depends on 5.10, only because of a single use of the // operator, this may be a bit suboptimal.
@drzigman
Copy link
Owner

It's an easy enough change to support older versions of Perl, I agree the change should be made. I should be able to get to this (and the #1 changes) shortly.

Thanks for pointing this out! I was not previously aware that // was introduced as late as 5.10.

@drzigman drzigman self-assigned this May 26, 2015
drzigman added a commit that referenced this issue Jun 10, 2015
@drzigman
Issue #4 - Remove dependancy on 5.10
a557acd 
The // operator was not introduced until 5.10 (Thanks @Leont for
pointing this out)

In Crypt::Rijndael::PP
  Updated setting of the default mode of ECB in new to not use //.
  Rather, just perform the shift and then if $mode was not defined set
  it equal to MODE_ECB();
drzigman added a commit that referenced this issue Jun 10, 2015
@drzigman
Updated dist.ini to run xt tests and added thanks to Leon Timmermans
450fb3b 
In dist.ini
  Included RunExtraTests module

In Crypt::Rijndael::PP (POD)
  Added thanks to Leon Timmermans for pointing out Issues #1 and #4
drzigman added a commit that referenced this issue Jun 10, 2015
@drzigman
Updated dist.ini to run xt tests and added thanks to Leon Timmermans
ff35f40 
In dist.ini
  Included RunExtraTests module

In Crypt::Rijndael::PP (POD)
  Added thanks to Leon Timmermans for pointing out Issues #1 and #4
@drzigman drzigman added this to the v0.3.0 milestone Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drzigman drzigman

Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@Leont @drzigman