Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive and maybe #95

Merged
merged 6 commits into from
Nov 15, 2017
Merged

Derive and maybe #95

merged 6 commits into from
Nov 15, 2017

Conversation

TrySound
Copy link
Collaborator

@TrySound TrySound commented Nov 15, 2017 •
edited
Loading

I talked with @andreypopp and think derive, maybeDerive and maybeDefault methods names can be better for readability.

@andreypopp
Copy link
Contributor

I like that, not sure though about maybeDefault. Originally I suggested orDefault as alt wasn't obvious to me.

@andreypopp
Copy link
Contributor

Should we also rename mReact to maybeReact?

@ds300
Copy link
Owner

ds300 commented Nov 15, 2017

👍 for orDefault

@TrySound
Copy link
Collaborator Author

Done.

@andreypopp
Copy link
Contributor

I really like how the API surface is shrinking :-)

@TrySound TrySound merged commit 8f1f3e8 into master Nov 15, 2017
@TrySound TrySound deleted the derive-and-maybe branch November 15, 2017 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TrySound @andreypopp @ds300