Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a GitHub Pages website for jetzt #105

Merged
merged 1 commit into from
Mar 20, 2014
Merged

Create a GitHub Pages website for jetzt #105

merged 1 commit into from
Mar 20, 2014

Conversation

nomicode
Copy link
Contributor

This PR creates a simple static GitHub Pages website for jetzt.

It includes information from the project's README.md, formatted in a more site-friendly way, plus a usable bookmarklet link. (This can be updated to the more recent version, once it is finalised.)

The site should look like this:

screen shot 2014-03-20 at 20 11 07

This design is intended to be a reasonable basis for further work, but may require some tweaking.

I have created a favicon.ico which I think is better than the current extension icon. If you agree, I can produce extension icons to match.

This PR is intended to close issues #77 and #56.

ds300 added a commit that referenced this pull request Mar 20, 2014
Create a GitHub Pages website for jetzt
@ds300 ds300 merged commit f4c6832 into ds300:master Mar 20, 2014
@ds300
Copy link
Owner

ds300 commented Mar 20, 2014

This is fantastic. 👍 Thank you!

@nomicode
Copy link
Contributor Author

Awesome. Thanks! :bowtie:

@nomicode nomicode deleted the new-website branch March 20, 2014 20:19
@h0ru5
Copy link
Collaborator

h0ru5 commented Mar 20, 2014

Nice! Already live at http://ds300.github.io/jetzt/

@nomicode
Copy link
Contributor Author

Yep. I have submitted this link to HN and Reddit now.

Hopefully get a bit more traffic from it.

@h0ru5
Copy link
Collaborator

h0ru5 commented Mar 20, 2014

the bookmarklet gives an error for me Uncaught SyntaxError: Unexpected end of input can anyone else confirm this? maybe some bracket missing in the end?

@nomicode
Copy link
Contributor Author

Some upvotes wouldn't hurt:

http://goo.gl/lc16bj
http://goo.gl/ZwgZe8

@h0ru5 oh crap, sorry. There was probably a mixup with me working from old files. I can confirm.

@h0ru5
Copy link
Collaborator

h0ru5 commented Mar 20, 2014

image

seems the quotes are borked

@nomicode
Copy link
Contributor Author

Was unsure what to do about #56. Do you know?

@nomicode
Copy link
Contributor Author

Lemme do a quick PR to fix the quotes here.

@h0ru5
Copy link
Collaborator

h0ru5 commented Mar 20, 2014

you just need to replace all " with ' inside the link.
its <a href="...">and inside that ... there should be no "

@h0ru5
Copy link
Collaborator

h0ru5 commented Mar 20, 2014

yupp, right. took me too long to type that crypto-liguistic haiku

@h0ru5
Copy link
Collaborator

h0ru5 commented Mar 20, 2014

about 56, we could/should use the code for a starter:

<script src="http://code.jquery.com/jquery-1.11.0.min.js"></script>
    <script type="text/javascript">
        $(function() {
            $.get( "bookmarklet.js", function( data ) {
                $("#bookmarklet").attr("href",data);
            },"text");
        });
    </script>

This looks very interesting: https://github.com/peteruithoven/jetzt/blob/add-bookmarklet/addbookmarklet.html
but I'm not sure about the offline-script, where to get it from (could be I missed a change in the grunt.js)

@peteruithoven, could you send in a PR?

@ds300
Copy link
Owner

ds300 commented Mar 20, 2014

@nslater I love the new Icon. Did you make a high-res version? We could use it for the chrome extension.

@nomicode
Copy link
Contributor Author

Okay! Created #107 to track it.

@peteruithoven
Copy link
Collaborator

I'll created a PR for the offline version:
#109

The only file you might missed was a bookmarklet-offline.js file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants