User Settings Support

[j6k4m8]

Don't merge me yet! I'm still cooking.

This PR begins support for users adding their own settings to the chrome extension.

[h0ru5]

hi, i'm currently working oin the same thing: see #35
My branch is on: https://github.com/h0ru5/jetzt/tree/options

lets merge it together there and push up a PR

[j6k4m8]

Ah gotcha, sorry for the repeat!

[h0ru5]

no worries, I just tossed some things around on dev, so it would be harder to merge

[j6k4m8]

Where would you like me to start? I'm looking at the branch but I'm not quite sure I follow what's going on.

[h0ru5]

in config.js are all options currently used in the script (DEFAULT_OPTIONS).
i use the same functions as the actual script to store and retrieve them.

we need add form elements to options.html (which needs to be beautified) for each setting.
Also any other options could be pulled out into that place.

Also, the functions opts2view and view2opts need to be updated then (but I currently think its better to use a data-binding such as angular.js here)

So if you could help ,me buffing up the html a bit?

[j6k4m8]

I found this https://github.com/zmyaro/crx-options-page in terms of
Chrome Extension CSS. Is there any reason to reinvent the wheel?

On Fri, Mar 14, 2014 at 5:20 PM, Johannes Hund notifications@github.comwrote:

in config.js are all options currently used in the script
(DEFAULT_OPTIONS).
i use the same functions as the actual script to store and retrieve them.

we need add form elements to options.html (which needs to be beautified)
for each setting.
Also any other options could be pulled out into that place.

Also, the functions opts2view and view2opts need to be updated then (but I
currently think its better to use a data-binding such as angular.js here)

So if you could help ,me buffing up the html a bit?

Reply to this email directly or view it on GitHubhttps://github.com//pull/68#issuecomment-37697795
.

[h0ru5]

looks exactly like what we need. It does provide a solid boilerplate

I did not go deep on the script yet, it does not store/retrieve configs, right?

[h0ru5]

only problem I see is that they did not provide a license...

[nomicode]

ZMYaro/crx-options-page#1 should fix that!

[h0ru5]

ok, I'll incorporate it, I also did add databinding with angular.js, so the view is very loosely coupled

[h0ru5]

@nslater by the way, since angular is MIT licence, can we use it in an Apache-Licenced project?

[nomicode]

MIT is compatible with the Apache Licence. (Most are.) I assume we'll vendor it in, and only ever update it by pulling from upstream? If so, it should present no problem.

If you like, I can put together a proper NOTICE and LICENSE file for the project. These files, when combined with the Apache License, properly set out all the necessary info. (And allow you to call out the licenses of any bundled software you've vendored into the codebase.)

[h0ru5]

wow, I am learning a lot here 👍
In the PR #69, i did add the lib under options/
Lets see what @ds300 thinks about it, then it would be cool if you could add the clearance files either after the PR is merged or onto my branch: https://github.com/h0ru5/jetzt/tree/options

[nomicode]

It's fine to do this after. We've not switched to the Apache Licence yet anyway, so that work needs to be complete before we do this. Created #71 to track this work.

[drhouse]

*Hi, I thought it might be of use to see a rough example of what an options menu/page might look like for jetzt. These (below) are from a spritz-related extension called Readline.

In regards to using custom fonts as mentioned here, perhaps there could be an extra input field with a radio button in, this example, the Font Family section, where a user could type the name of any font on their system and select to use it.

Maybe there could be a Style section for the different css elements, with input fields to enter custom color hex codes or the use of color pickers.

*(note: links fixed, an extension removed them from this post earlier)

[nomicode]

Thanks for the link.

For now, I'm collecting similar projects on the wiki.

[ds300]

Good call on using angular for the options forms. It makes that stuff so easy 👍

[drhouse]

just a note, links fixed in my last post, an extension removed them while editing earlier, now it might make more sense :)