-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User Settings Support #68
Conversation
hi, i'm currently working oin the same thing: see #35 lets merge it together there and push up a PR |
Ah gotcha, sorry for the repeat! |
no worries, I just tossed some things around on dev, so it would be harder to merge |
Where would you like me to start? I'm looking at the branch but I'm not quite sure I follow what's going on. |
in config.js are all options currently used in the script (DEFAULT_OPTIONS). we need add form elements to options.html (which needs to be beautified) for each setting. Also, the functions opts2view and view2opts need to be updated then (but I currently think its better to use a data-binding such as angular.js here) So if you could help ,me buffing up the html a bit? |
I found this https://github.com/zmyaro/crx-options-page in terms of On Fri, Mar 14, 2014 at 5:20 PM, Johannes Hund notifications@github.comwrote:
|
looks exactly like what we need. It does provide a solid boilerplate I did not go deep on the script yet, it does not store/retrieve configs, right? |
only problem I see is that they did not provide a license... |
ZMYaro/crx-options-page#1 should fix that! |
ok, I'll incorporate it, I also did add databinding with angular.js, so the view is very loosely coupled |
@nslater by the way, since angular is MIT licence, can we use it in an Apache-Licenced project? |
MIT is compatible with the Apache Licence. (Most are.) I assume we'll vendor it in, and only ever update it by pulling from upstream? If so, it should present no problem. If you like, I can put together a proper NOTICE and LICENSE file for the project. These files, when combined with the Apache License, properly set out all the necessary info. (And allow you to call out the licenses of any bundled software you've vendored into the codebase.) |
wow, I am learning a lot here 👍 |
It's fine to do this after. We've not switched to the Apache Licence yet anyway, so that work needs to be complete before we do this. Created #71 to track this work. |
*Hi, I thought it might be of use to see a rough example of what an options menu/page might look like for jetzt. These (below) are from a spritz-related extension called Readline. In regards to using custom fonts as mentioned here, perhaps there could be an extra input field with a radio button in, this example, the Font Family section, where a user could type the name of any font on their system and select to use it. Maybe there could be a Style section for the different css elements, with input fields to enter custom color hex codes or the use of color pickers. *(note: links fixed, an extension removed them from this post earlier) |
Thanks for the link. For now, I'm collecting similar projects on the wiki. |
Good call on using angular for the options forms. It makes that stuff so easy 👍 |
just a note, links fixed in my last post, an extension removed them while editing earlier, now it might make more sense :) |
Don't merge me yet! I'm still cooking.
This PR begins support for users adding their own settings to the chrome extension.