[gh-8] Fixes for Windows

[ashmind]

Notes:

• Updated to cross-spawn, based on Windows doesn't like single quotes xxorax/node-shell-escape#9 (comment).
• Replaced patch with git apply — patch is not installed by default on Windows, while git is already used by this package.
• Tested make patch and it works properly on Windows
• Tested apply patch and it works properly on Windows

[ds300]

Thanks for the work on this. Unfortunately it breaks patching on macOS :/ the git apply commands exit with 0 status, but the patches don't get applied.

[ds300]

Hmm my bad. It seems to be working after all. Not sure what I was doing wrong when testing before.

[ds300]

The issue was that when the patch can't be applied it fails silently. I think you just need to change the way that the error condition is checked in spawnSafe. Instead of checking for result.error you need to check whether result.status > 0. Maybe both, if failures on windows are encoded in the result.error property.

[ashmind]

@ds300 Right -- stupid mistake.
I think error is for system errors (e.g. file not found) -- you are right that I should check both.

I'll update and retest.

[ashmind]

@ds300 Recreated the commit -- now checks for status and logs the stderr on failure.

[ds300]

Looks good, thanks! I'll test again tonight.

[ds300]

This is good good stuff, thanks! Just a couple of tiny changes. The logging suppression thing mentioned elsewhere, and also rebase on my master branch and run yarn format to make the code nice and pretty :)

[ds300]

Can you add an option to suppress this logging, and make sure that it doesn't happen for any of the patch application commands? It prints errors in cases where the patch was already applied.

[ashmind]

@ds300 Sure, just applied the changes.

[ashmind]

@ds300 Please feel free to rename the option name if you can think of a better one.

[ds300]

Yay, thanks again! 🎉

[ds300]