Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalized edge coefficients in node bipartite observation #270

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Normalized edge coefficients in node bipartite observation #270

merged 1 commit into from
Oct 27, 2021

Conversation

dchetelat
Copy link
Contributor

Pull request checklist

  • I have opened an issue to discuss the proposed changes: Fix #XX.
  • I have modified/added tests to cover the new changes/features.
  • I have modified/added the documentation to cover the new changes/features.
  • I have ran the tests, checks, and code formatters.

Proposed implementation

Edge coefficients in NodeBipartiteObs are now row-normalized.

@dchetelat dchetelat linked an issue Oct 27, 2021 that may be closed by this pull request
NodeBipartite does not normalize row coefficients properly #263
Closed
AntoinePrv
AntoinePrv approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@AntoinePrv AntoinePrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntoinePrv AntoinePrv merged commit a19df4d into latest Oct 27, 2021
@AntoinePrv AntoinePrv deleted the nodebipartite_normalization branch October 27, 2021 19:22
@dchetelat dchetelat changed the title Normalized edge coefficients in node ipartite observation Normalized edge coefficients in node bipartite observation Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntoinePrv AntoinePrv AntoinePrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NodeBipartite does not normalize row coefficients properly
2 participants
@dchetelat @AntoinePrv