Set Now Playing Scroll Speed to 0 or turn off

[chippleh1392]

Would it be possible to set Now Playing Scroll Speed to 0 or turned off? I noticed whenever I set the speed to 0, it instead changes the speed to 1.

[dsafa]

I will fix that. It should be able to be set to 0.

[chippleh1392]

I might have a fix for this. Is there a good way to test changes on a system that already has the current version installed?

[dsafa]

I'm not sure of a way to do that. What kind of changes are you proposing?

[chippleh1392]

I could be wrong but I think the metro:NumericUpDown for "ScrollSpeedLabelText" in CustomLabelSettingsView.xaml designer needs to have the argument "Minimum = 0" added. It seems that metro labels with NumericInput.Type="Size" default to a Minimum of 1. Let me know if I'm way off base. Thanks!

[dsafa]

You are right with the minimum being set to 1 due to the NumericInput.Type = Size. Instead of specifically changing it to Minimum=0, I believe I created a NumericInputType that sets the range to 0+

Feel free to make a pull request with the changes. Thanks.

[chippleh1392]

I see the options for NumericInputType are:

    /// <summary>
    /// Greater than 0.
    /// </summary>
    Size,

    /// <summary>
    /// Any integer value
    /// </summary>
    Position,

    /// <summary>
    /// Floating point greater than 0.
    /// </summary>
    FontSize,

    /// <summary>
    /// Integer greater than 0.
    /// </summary>
    Positive,

    /// <summary>
    /// Any integer.
    /// </summary>
    Integer,

Size, FontSize, and Positive are all strictly greater than 0. Position and Integer are for any integer value, which could include negative values (which I'm assuming we don't want),

Is there an appropriate NumericInputType listed here?

Also, where are these NumericInputTypes originally defined? In the Metro.Controls project? Pardon my ignorance on this, I'm still trying to understand exactly what I'm looking at here.

Thanks!

[dsafa]

Thats my fault for the confusion. Positive should be 0 or greater, should update that comment. The type is defined in this project.

What I'm doing is using NumericInputType in an attached property NumericInput. Then I apply a style that sets properties (eg. Min and Max values) for NumericUpDown controls based on the attached property. Check the style to see what I defined. Now that I look at it, I defined positive twice which is a bug.

Maybe positive should be kept as 1 or greater and a WholeNumber entry should be created.

[chippleh1392]

Thanks for the info. I committed the changes to my fork here.

Everything looks good in Visual Studio but I still don't know how to test changes without doing a new install. If you think it looks good I can do a pull request.

[dsafa]

For now the only way to test is to overwrite the install unfortunately. I have some idea for plans for a test harness so that it doesn't have to be installed to the toolbar.

I took a look at your fork and everything looks good!

[Waliactico]

Also interested in this, will this be added in next update?

[dsafa]

yep, the next update is just really big so its taking a while.

[dsafa]

Closing finished issues (v0.9)