Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max size deskband options #30

Closed
dsafa opened this issue Apr 25, 2018 · 0 comments
Closed

Fix max size deskband options #30

dsafa opened this issue Apr 25, 2018 · 0 comments
Assignees
@dsafa
Milestone
v2

Comments

@dsafa
Copy link
Owner

dsafa commented Apr 25, 2018

It should actually be integers max height when horizontal and max width when vertical instead of a Size struct
@dsafa dsafa added this to the v2 milestone Apr 25, 2018
@dsafa dsafa self-assigned this Apr 25, 2018
dsafa added a commit that referenced this issue Aug 16, 2018
@dsafa
Update deskband options that control the size
06bb77e 
Changes to CSDeskBandOptions:
- Rename property MinVertical -> MinVerticalSize
- Rename property MaxVertical -> MaxVerticalWidth; Also changes the data type from Size to an int because there is only one value
- Rename property Vertical -> VerticalSize
- Rename property MinHorizontal -> MinHorizontalSize
- Rename property MaxHorizontal -> MaxHorizontalHeight; Also changes the data type from Size to an int because there is only one value
- Update documentation comments for those properties
- [Github] closes #30
@dsafa dsafa closed this as completed in c162460 Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsafa dsafa

Labels
None yet
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@dsafa