Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mess with self-closed tag inside a tag with the same name #20

Closed
ruv opened this issue May 10, 2017 · 1 comment
Closed

Mess with self-closed tag inside a tag with the same name #20

ruv opened this issue May 10, 2017 · 1 comment
Labels

Comments

@ruv
Copy link

ruv commented May 10, 2017

This add-on is affected by the same bug as bracket-matcher regarding self-closed tags.

For example, in the fragment:

<div>
  <div /><!-- testcase: try to rename this div into hr -->
</div>

If you change the inner div to hr, the outer div end tag will be incorrectly changed.

It seems that the corresponded code is duplicated in many addons. Why don't to have it in some common library?

@dsandstrom
Copy link
Owner

This is fixed by v1.4.1. When you edit the self-closed tag, the outer tags shouldn't change. However, the outer tags still don't behave correctly. When you edit the starting div, the ending div is not affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants