Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

bracket-matcher:close-tag does not skip self-closing tags #203

Closed
pvorona opened this issue Jan 2, 2016 · 9 comments · Fixed by #304
Closed

bracket-matcher:close-tag does not skip self-closing tags #203

pvorona opened this issue Jan 2, 2016 · 9 comments · Fixed by #304
Labels

Comments

@pvorona
Copy link

pvorona commented Jan 2, 2016

<Scalable width={props.width} height={props.height}>
    <SimplePlot {...props} />
[Cursor here]

When i use command to close tag, i get </SimplePlot> which is already self-closed. I should get </Scalable> instead.

@lee-dohm
Copy link
Contributor

lee-dohm commented Jan 2, 2016

Reproduced using Atom v1.3.2 on Mac OS X 10.11.2.

@lee-dohm lee-dohm added the bug label Jan 2, 2016
@luisrudge
Copy link

I'm seeing an issue that looks like this one:
image

@vndmtrx
Copy link

vndmtrx commented May 11, 2016

Reproduced too on Atom 1.8.0-beta3 on Windows 10.
captura de tela 2016-05-11 16 56 33

@MoritzKn
Copy link
Contributor

I fixed this and opened a PR: #273

@deanchao
Copy link

image

Got this problem too

@hibiyasleep
Copy link

hibiyasleep commented Jun 27, 2017

PR #273 partly fixed this issue, but it seems only for 'known to self-closing' tags.

More examples here:
2017-06-27 16 05 56
2017-06-27 16 05 37
2017-06-27 16 03 52

ps: language set to HTML.

@MoritzKn
Copy link
Contributor

@hibiyasleep #273 only fixed the behavior of bracket-matcher:close-tag. #257 will fix the highlighting of corresponding tags.

@50Wliu
Copy link
Contributor

50Wliu commented Jul 21, 2017

Both PRs have been merged.

@50Wliu 50Wliu closed this as completed Jul 21, 2017
@ungb
Copy link
Contributor

ungb commented Aug 7, 2017

we found a performance regression so had to revert the change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants