Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override findById #66

Closed
wants to merge 1 commit into from
Closed

Override findById #66

wants to merge 1 commit into from

Conversation

m-weeks
Copy link

@m-weeks m-weeks commented Oct 17, 2019

I figured this would be a handy feature, so that instead of always having to do findOne({ _id: <id> }) to ensure deleted models aren't returned, findById could be used

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.658% when pulling 399d5aa on m-weeks:master into b9a12d7 on dsanel:master.

@m-weeks
Copy link
Author

m-weeks commented Oct 17, 2019

Upon further inspection I noticed this PR does not solve the issue. Opened issue #67

@m-weeks m-weeks closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m-weeks @coveralls