icns icon no longer works as macOS platform icon (resolves #68).

dscalzi · May 24, 2020 · 1430d0f · 1430d0f
1 parent 8726638
commit 1430d0f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 15 deletions.
diff --git a/index.js b/index.js
@@ -193,16 +193,19 @@ function createMenu() {
 }
 
 function getPlatformIcon(filename){
-    const opSys = process.platform
-    if (opSys === 'darwin') {
-        filename = filename + '.icns'
-    } else if (opSys === 'win32') {
-        filename = filename + '.ico'
-    } else {
-        filename = filename + '.png'
+    let ext
+    switch(process.platform) {
+        case 'win32':
+            ext = 'ico'
+            break
+        case 'darwin':
+        case 'linux':
+        default:
+            ext = 'png'
+            break
     }
 
-    return path.join(__dirname, 'app', 'assets', 'images', filename)
+    return path.join(__dirname, 'app', 'assets', 'images', `${filename}.${ext}`)
 }
 
 app.on('ready', createWindow)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -43,7 +43,7 @@
     "cross-env": "^7.0.2",
     "electron": "^9.0.0",
     "electron-builder": "^22.6.1",
-    "eslint": "^7.0.0"
+    "eslint": "^7.1.0"
   },
   "repository": {
     "type": "git",