Adds a fix for calculating position. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rlasch I'm finding it hard to find time to review this. Everything seems great but I would really be thankful if you could find a teammate to review this perhaps, so i can feel some sort of code review happened? If not just hang on a little more until i can review, and will publish Thanks for the contribution, taking the time and writing an test which is great. |
dscape
added a commit
that referenced
this pull request
May 11, 2015
Adds a fix for calculating position.
|
Merged, sorry it took me so long |
|
No worries Nuno! I've been working off of a branch of this. I'm probably Thanks! On Mon, May 11, 2015 at 9:29 AM Nuno Job notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.