Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the package.json formatting to allow for better parsing by NPM #25

Closed
wants to merge 1 commit into from

Conversation

lewisdaly
Copy link

This Pull request formats the package.json file to use standard JSON formatting.

While the existing package.json file is technically valid JSON, it uses non-standard formatting which actually breaks some features in npm install.

For example, when running npm install, and inspecting the resulting package.json file inside of the node_modules folder, there are a few fields missing, namely the 'license' field.

node_modules/cycle/package.json before this change:

  . . .
  "keywords": [
    "json",
    "cycle",
    "stringify",
    "parse"
  ],
  "main": "./cycle.js",
  "name": "cycle",
  "repository": {
    "type": "git",
    "url": "git+ssh://git@github.com/dscape/cycle.git"
  },
  "version": "1.0.3"
}

and after this change:

  . . .
  "keywords": [
    "json",
    "cycle",
    "stringify",
    "parse"
  ],
  "license": "Public-Domain",
  "main": "./cycle.js",
  "name": "cycle",
  "repository": {
    "type": "git",
    "url": "git+ssh://git@github.com/dscape/cycle.git"
  },
  "version": "1.0.3"
}

@dscape
Copy link
Owner

dscape commented Aug 7, 2019 via email

@lewisdaly lewisdaly closed this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants