Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cycle #4

Merged
merged 1 commit into from Dec 16, 2013
Merged

Update cycle #4

merged 1 commit into from Dec 16, 2013

Conversation

jwarkentin
Copy link
Contributor

No description provided.

@dscape
Copy link
Owner

dscape commented Dec 16, 2013

Sweet! 👍

However you changed the API here.

So far it was:

var cycle = require('cycle')

Now it's

JSON.cycle

While this is perfectly fine from a technical perspective it is a breaking API change for people using cycle no?

Please let me know if I'm incorrect here. If I am I'll take the PR and publish it. If not please commit just the changed lines from the new cycle and I'll publish.

@jwarkentin
Copy link
Contributor Author

Sorry, I just copied and pasted. I didn't pay attention to the modification you had made. I just updated the PR.

dscape added a commit that referenced this pull request Dec 16, 2013
@dscape dscape merged commit 455fd23 into dscape:master Dec 16, 2013
@dscape
Copy link
Owner

dscape commented Dec 16, 2013

Published:

$ npm publish
npm http PUT https://registry.npmjs.org/cycle
npm http 409 https://registry.npmjs.org/cycle
npm http GET https://registry.npmjs.org/cycle
npm http 200 https://registry.npmjs.org/cycle
npm http PUT https://registry.npmjs.org/cycle/-/cycle-1.0.3.tgz/-rev/7-143cab8983d7b0e5a0774b18aec25d2f
npm http 201 https://registry.npmjs.org/cycle/-/cycle-1.0.3.tgz/-rev/7-143cab8983d7b0e5a0774b18aec25d2f
npm http PUT https://registry.npmjs.org/cycle/1.0.3/-tag/latest
npm http 201 https://registry.npmjs.org/cycle/1.0.3/-tag/latest
+ cycle@1.0.3

Keep an eye on issues for the next week or two. You might be surprised on what happens with "small" changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants