This repository has been archived by the owner on Nov 5, 2018. It is now read-only.
db name encoding fix #105
Closed
db name encoding fix #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a test for this. not really 100% sure it works, but all tests are passing.
|
Merged on f9690bc |
dscape
added a commit
that referenced
this pull request
Oct 10, 2012
* adds paul to contributors list * fixes encoding of database bug #105
KangTheTerrible
pushed a commit
to KangTheTerrible/nano
that referenced
this pull request
Aug 19, 2018
tape-it should have moved over with nano, it’s a tape harness config, but binds us to an old version of tape. I tried a simple copy and paste, while keeping the tape version, but getting npm t issues. This is a three-step process: 1. copy `dscape/tape-it/index.js` to `test/helpers/harness.js` 2. update the `require` in `test/helpers/integration.js` 3. make tests work It leads us to the fun situation where our integration tests are run with tape version ^3.0.1 and the rest with 4.6.2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for dbs with names that use
$ + /
to be encoded as:
%24 %2B %2F