Skip to content

Commit

Permalink
ADGroup: Refactor Module, Unit and Integration Tests (#631)
Browse files Browse the repository at this point in the history
This PR refactors the module, unit and integration tests of the ADGroup resource as follows:

- Remove non mandatory parameters from Get-TargetResource.
- Remove nested Try/Catch blocks from Get-TargetResource.
- Refactor Test-TargetResource to use Compare-ResourcePropertyState common function.
- Refactor Set-TargetResource to use Compare-ResourcePropertyState common function.
- Modify membership add/Remove to use Compare-Object to only add/remove changed members.
- Fix Set-ADCommonGroupMember function so parameters are not changed.
- Fix Credential parameter description.
- Enhance integration tests to use a data driven pattern.
- Enhance unit tests to use contexts and newer standard test patterns.
  • Loading branch information
X-Guardian committed Jan 24, 2021
1 parent 45379fc commit 9346a1d
Show file tree
Hide file tree
Showing 11 changed files with 1,974 additions and 2,720 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)

## [Unreleased]

### Changed

- ADGroup
- Refactored Module.
- Refactored Unit and Integration Tests.

### Added

- ADGroup
Expand Down
Loading

0 comments on commit 9346a1d

Please sign in to comment.