Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADReplicationSite: Integration tests is missing for this resource #355

Closed
johlju opened this issue Jun 7, 2019 · 2 comments · Fixed by #501
Closed

ADReplicationSite: Integration tests is missing for this resource #355

johlju opened this issue Jun 7, 2019 · 2 comments · Fixed by #501
Labels
tests The issue or pull request is about tests only.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented Jun 7, 2019

We should add integration tests for this resource.
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only. labels Jun 7, 2019
@johlju johlju added this to To do in All issues and PR's Jun 7, 2019
@johlju johlju changed the title xADReplicationSite: Integration tests is missing for this resource ADReplicationSite: Integration tests is missing for this resource Jul 28, 2019
@1800Zeta
Copy link
Contributor

I am looking to add 'Description' attribute to this resource so will have a crack at Integration tests at the same time.

@1800Zeta 1800Zeta mentioned this issue Sep 13, 2019
Merged
10 tasks
@johlju
Copy link
Member Author

johlju commented Sep 13, 2019

Cool thank you!

@johlju johlju added in progress The issue is being actively worked on by someone. and removed help wanted The issue is up for grabs for anyone in the community. labels Sep 17, 2019
All issues and PR's automation moved this from To do to Done Sep 20, 2019
johlju pushed a commit that referenced this issue Sep 20, 2019
@1800Zeta @johlju
AdReplicationSite: Adding description attribute, will create integrat…
83903b2 
…ion tests (#501)

- Changes to ADReplicationSite
  - Added 'Description' attribute parameter (issue #500).
  - Added Integration testing (issue #355).
  - Correct value returned for RenameDefaultFirstSiteName (issue #502).
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests The issue or pull request is about tests only.
Projects
All issues and PR's
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

AdReplicationSite: Adding description attribute, will create integration tests
2 participants
@johlju @1800Zeta