Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADReplicationSubnet: Integration tests is missing for this resource #357

Closed
johlju opened this issue Jun 7, 2019 · 1 comment · Fixed by #507
Closed

ADReplicationSubnet: Integration tests is missing for this resource #357

johlju opened this issue Jun 7, 2019 · 1 comment · Fixed by #507
Labels
tests The issue or pull request is about tests only.
Projects
All issues and PR's

Comments

@johlju
Copy link
Member

johlju commented Jun 7, 2019

We should add integration tests for this resource.
@johlju johlju added help wanted The issue is up for grabs for anyone in the community. tests The issue or pull request is about tests only. labels Jun 7, 2019
@johlju johlju added this to To do in All issues and PR's Jun 7, 2019
@johlju johlju changed the title xADReplicationSubnet: Integration tests is missing for this resource ADReplicationSubnet: Integration tests is missing for this resource Jul 28, 2019
@1800Zeta
Copy link
Contributor

I have written integration tests as part of adding the description field in #503 Will submit PR for this change soon

@1800Zeta 1800Zeta mentioned this issue Sep 19, 2019
Merged
10 tasks
All issues and PR's automation moved this from To do to Done Sep 25, 2019
johlju pushed a commit that referenced this issue Sep 25, 2019
@1800Zeta @johlju
ADReplicationSubnet: Add Integration Testing, Add Description (#507)
3e96da3 
- Changes to ADReplicationSubnet
  - Added 'Description' attribute parameter (issue #503)
  - Added Integration testing (issue #357)
@johlju johlju removed the help wanted The issue is up for grabs for anyone in the community. label Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests The issue or pull request is about tests only.
Projects
All issues and PR's
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ADReplicationSubnet: Add Integration Testing, Add Description
2 participants
@johlju @1800Zeta