Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActiveDirectoryDsc: To lenient when to raise minor version #588

Closed
johlju opened this issue Apr 9, 2020 · 0 comments · Fixed by #589
Closed

ActiveDirectoryDsc: To lenient when to raise minor version #588

johlju opened this issue Apr 9, 2020 · 0 comments · Fixed by #589
Labels
enhancement The issue is an enhancement request.

Comments

@johlju
Copy link
Member

johlju commented Apr 9, 2020 •
edited
Loading

For example if the commit message contains the word ADDomain or additional it raises the minor version even if only patch version should be raised.

For example the commit message Fix an additional exception message to ADDomain. would raise the minor version even if the intent was to raise the patch version.

Suggest changing the regular expression for minor-version-bump-message in GitVersion.yml to:

(adds?|features?|minor)\b
@johlju johlju changed the title ActiveDirectory: To lenient when to raise minor version ActiveDirectoryDsc: To lenient when to raise minor version Apr 9, 2020
@johlju johlju added enhancement The issue is an enhancement request. in progress The issue is being actively worked on by someone. labels Apr 9, 2020
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 9, 2020
@johlju
Fix regular expression for minor-version-bump-message (issue dsccommu…
2033b06 
…nity#588)
@johlju johlju mentioned this issue Apr 9, 2020
Merged
9 tasks
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 9, 2020
@johlju
Fix regular expression for bumping version (issue dsccommunity#588)
bd8ee44
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this issue Apr 9, 2020
@johlju
Fix regular expression for bumping version (issue dsccommunity#588)
6a58638
X-Guardian pushed a commit that referenced this issue Apr 9, 2020
@johlju
ActiveDirectoryDsc: Fix regex for bumping version (#589)
c5ebb76 
* Fix regular expression for bumping version (issue #588)

* Only run CI pipeline on changes to files in source

* Update CHANGELOG.md
@johlju johlju removed the in progress The issue is being actively worked on by someone. label Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement The issue is an enhancement request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ActiveDirectoryDsc: Fix regex for bumping version johlju/ActiveDirectoryDsc
1 participant
@johlju