Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xActiveDirectory: Adding a Branches section to the README.md #193

Merged
merged 2 commits into from
May 24, 2018

Conversation

johlju
Copy link
Member

@johlju johlju commented May 21, 2018

Fixes #192


This change is Reviewable

@codecov-io
Copy link

codecov-io commented May 21, 2018

Codecov Report

Merging #193 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #193   +/-   ##
===================================
  Coverage    80%    80%           
===================================
  Files        14     14           
  Lines      1084   1084           
  Branches     10     10           
===================================
  Hits        871    871           
  Misses      203    203           
  Partials     10     10

@johlju johlju added the needs review The pull request needs a code review. label May 21, 2018
@awickham10
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

- Adding a Branches section to the README.md with Codecov badges for both
  master and dev branch (issue dsccommunity#192).
@johlju
Copy link
Member Author

johlju commented May 23, 2018

@awickham10 Needed to rebase, could you sign-off again?

@awickham10
Copy link
Contributor

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@awickham10
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@johlju johlju merged commit 6c6599f into dsccommunity:dev May 24, 2018
@johlju johlju removed the needs review The pull request needs a code review. label May 24, 2018
@johlju johlju deleted the add-badges branch May 24, 2018 11:46
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this pull request Apr 19, 2019
…unity#193)

- Changes to xActiveDirectory
  - Adding a Branches section to the README.md with Codecov badges for both
    master and dev branch (issue dsccommunity#192).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants