xActiveDirectory: MSFT_xADCommon.ps1 is renamed to MSFT_xADCommon.psm1 #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #202 +/- ##
====================================
+ Coverage 80% 81% +1%
====================================
Files 14 14
Lines 1084 1214 +130
Branches 10 10
====================================
+ Hits 871 990 +119
- Misses 203 214 +11
Partials 10 10 |
johlju
changed the title
|
Reviewed 10 of 10 files at r1. Comments from Reviewable |
complete! all files reviewed, all discussions resolved
johlju
added a commit
to johlju/ActiveDirectoryDsc
that referenced
this pull request
Apr 19, 2019
dsccommunity#202) - The helper function script file MSFT_xADCommon.ps1 was renamed to MSFT_xADCommon.psm1 to be a module script file instead. This makes it possible to report code coverage for the helper functions (issue dsccommunity#201).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
This change is