Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Issue #340 #339 #335 #330 #440

Merged
merged 3 commits into from
Jul 21, 2019

Conversation

kungfoome
Copy link

@kungfoome kungfoome commented Jul 21, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Jul 21, 2019
Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Just tiny comments.

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kungfu71186)


CHANGELOG.md, line 75 at r1 (raw file):

modules

From the user perspective this should be: resources


DSCResources/MSFT_xADDomain/MSFT_xADDomain.psm1, line 49 at r1 (raw file):

<# Get-TargetResource

Should just be <#. Throughout all comment-based help.

@johlju johlju added waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. and removed needs review The pull request needs a code review. labels Jul 21, 2019
@codecov-io
Copy link

Codecov Report

Merging #440 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #440   +/-   ##
===================================
  Coverage    96%    96%           
===================================
  Files        20     20           
  Lines      2705   2705           
  Branches     10     10           
===================================
  Hits       2608   2608           
  Misses       87     87           
  Partials     10     10

Copy link
Author

@kungfoome kungfoome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @johlju)


CHANGELOG.md, line 75 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
modules

From the user perspective this should be: resources

Done.


DSCResources/MSFT_xADDomain/MSFT_xADDomain.psm1, line 49 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
<# Get-TargetResource

Should just be <#. Throughout all comment-based help.

Done.

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 621e285 into dsccommunity:dev Jul 21, 2019
@johlju johlju removed the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants