-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Issue #340 #339 #335 #330 #440
Conversation
…sccommunity#330. Add in comment based help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! Just tiny comments.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kungfu71186)
CHANGELOG.md, line 75 at r1 (raw file):
modules
From the user perspective this should be: resources
DSCResources/MSFT_xADDomain/MSFT_xADDomain.psm1, line 49 at r1 (raw file):
<# Get-TargetResource
Should just be <#
. Throughout all comment-based help.
Codecov Report
@@ Coverage Diff @@
## dev #440 +/- ##
===================================
Coverage 96% 96%
===================================
Files 20 20
Lines 2705 2705
Branches 10 10
===================================
Hits 2608 2608
Misses 87 87
Partials 10 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @johlju)
CHANGELOG.md, line 75 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
modules
From the user perspective this should be: resources
Done.
DSCResources/MSFT_xADDomain/MSFT_xADDomain.psm1, line 49 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
<# Get-TargetResource
Should just be
<#
. Throughout all comment-based help.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Pull Request (PR) description
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is