Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xActiveDirectory: Removing SupportsShouldProcess #441

Merged
merged 3 commits into from
Jul 22, 2019

Conversation

johlju
Copy link
Member

@johlju johlju commented Jul 21, 2019

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes #329
Fixes #328

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

- Changes to xADObjectPermissionEntry
  - Remove remnants of the `SupportsShouldProcess` (issue dsccommunity#329).
- Changes to xADRecycleBin
  - Removed `SupportsShouldProcess` from the resource since DSC does not
    support that interactive function (issue dsccommunity#328).
@johlju johlju added the needs review The pull request needs a code review. label Jul 21, 2019
@codecov-io
Copy link

codecov-io commented Jul 21, 2019

Codecov Report

Merging #441 into dev will decrease coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #441   +/-   ##
===================================
- Coverage    96%    96%   -1%     
===================================
  Files        20     20           
  Lines      2705   2704    -1     
  Branches     10     10           
===================================
- Hits       2608   2607    -1     
  Misses       87     87           
  Partials     10     10

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 5 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit 7e5344a into dsccommunity:dev Jul 22, 2019
@johlju johlju removed the needs review The pull request needs a code review. label Jul 22, 2019
@johlju johlju deleted the fix-issue-329 branch July 22, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants