ActiveDirectoryDsc.Common: Refactor Remove-DuplicateMembers

[johlju]

Pull Request (PR) description

• Changes to ActiveDirectoryDsc.Common:
  • Refactor Remove-DuplicateMembers and added more unit tests (issue ActiveDirectoryDsc.Common: Refactor Remove-DuplicateMembers #443).
  • Minor cleanup in Test-Members because of the improved Remove-DuplicateMembers.
  • Minor cleanup in Assert-MemberParameters because of the improved Remove-DuplicateMembers.

This Pull Request (PR) fixes the following issues

• Fixes ActiveDirectoryDsc.Common: Refactor Remove-DuplicateMembers #443

Task list

• Added an entry under the Unreleased section in the CHANGELOG.md.
  Entry should say what was changed, and how that affects users (if applicable).
• Resource documentation added/updated in resource directory README.md.
• Resource parameter descriptions added/updated in schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Conceptual help topic added/updated (cultureFolder\about_ResourceName.help.txt).
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Resource Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
• New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

---

This change is 

[codecov-io]

Codecov Report

Merging #471 into dev will decrease coverage by <1%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #471   +/-   ##
===================================
- Coverage    98%    98%   -1%     
===================================
  Files        20     20           
  Lines      2865   2856    -9     
  Branches     10     10           
===================================
- Hits       2816   2807    -9     
  Misses       39     39           
  Partials     10     10

[johlju]

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion

---

Tests/Unit/ActiveDirectory.Common.Tests.ps1, line 703 at r3 (raw file):

-Be $true

Let us change this to -BeTrue to be consequent. Throughout.

[johlju]

Reviewable status: complete! all files reviewed, all discussions resolved

---

Tests/Unit/ActiveDirectory.Common.Tests.ps1, line 703 at r3 (raw file):

Previously, johlju (Johan Ljunggren) wrote…

-Be $true

Let us change this to -BeTrue to be consequent. Throughout.

Done. I will send in a PR that resolves throughout the repo instead.