Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Update Pipeline files to latest pattern - Fixes #262 #266

Merged
merged 2 commits into from
Apr 15, 2022

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Apr 11, 2022

Pull Request (PR) description

This PR updates the pipeline agents to the supported versions. It also updates pipeline files to the latest pattern.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - another one for you to review when you have time.


This change is Reviewable

@PlagueHO PlagueHO added the needs review The pull request needs a code review. label Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #266 (c78f852) into main (137a69f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #266   +/-   ##
===================================
  Coverage    84%    84%           
===================================
  Files         7      7           
  Lines       929    929           
===================================
  Hits        786    786           
  Misses      143    143           

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju merged commit a541b45 into dsccommunity:main Apr 15, 2022
@johlju johlju removed the needs review The pull request needs a code review. label Apr 15, 2022
@PlagueHO PlagueHO deleted the Issue-262 branch April 16, 2022 06:22
cmielke pushed a commit to cmielke/CertificateDsc that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI Pipeline Files from Latest Pattern Update Azure DevOps Pipeline Images
2 participants