Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#255] Fixed type mismatch for MultipleInstances #256

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

bozho
Copy link
Contributor

@bozho bozho commented Aug 29, 2019

Pull Request (PR) description

Fixes ScheduledTask MultipleInstances type mismatch in Get-TargeResource

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in the resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #256 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #256   +/-   ##
===================================
  Coverage    88%    88%           
===================================
  Files        12     12           
  Lines      1398   1398           
===================================
  Hits       1231   1231           
  Misses      167    167

@PlagueHO
Copy link
Member

PlagueHO commented Sep 4, 2019

Hi @bozho - can you fix the conflicts on this one and I'll get it reviewed? Thank you! 😁

@PlagueHO PlagueHO added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Sep 4, 2019
@bozho bozho force-pushed the issue-255-sch-task-type-mismatch branch from 82761c8 to 58144bb Compare September 4, 2019 08:36
@bozho
Copy link
Contributor Author

bozho commented Sep 6, 2019

@PlagueHO Done :)

Copy link
Member

@PlagueHO PlagueHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PlagueHO PlagueHO merged commit 0d65d74 into dsccommunity:dev Sep 6, 2019
@bozho bozho deleted the issue-255-sch-task-type-mismatch branch September 9, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScheduledTask: Type mismatch with MultipleInstances option
3 participants