Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Code Coverage and fix Publish #369

Merged
merged 1 commit into from Apr 15, 2021
Merged

Conversation

PlagueHO
Copy link
Member

@PlagueHO PlagueHO commented Apr 11, 2021

Pull Request (PR) description

This PR adds Code Coverage support, fixes an issue with Publishing the module (due to the case being wrong on the tasks - I think) and updates Sampler.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md in resource folder.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

@johlju - would you mind reviewing when you get time? I think I have an issue in all modules where publish is failing because the case of the Sampler tasks has changed. But I've yet to confirm.


This change is Reviewable

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PlagueHO)

@johlju johlju merged commit cc2ebb5 into dsccommunity:main Apr 15, 2021
@PlagueHO PlagueHO deleted the Issue-368 branch April 16, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Publish Failure Enable Code Coverage Reporting Update Sampler Build Tasks
2 participants