Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSC_Computer: Fix for Delete-ADSIObject #415

Merged
merged 2 commits into from Jul 17, 2023
Merged

Conversation

rcarpenter79
Copy link
Contributor

@rcarpenter79 rcarpenter79 commented Jul 17, 2023

Pull Request (PR) description

This fixes the function Delete-ADSIObject by changing the variable used when creating System.DirectoryServices.DirectoryEntry.

This Pull Request (PR) fixes the following issues

Fixes #414

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #415 (4fb3695) into main (fcff2e0) will decrease coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #415   +/-   ##
===================================
- Coverage    90%    90%   -1%     
===================================
  Files        18     18           
  Lines      1802   1801    -1     
===================================
- Hits       1629   1628    -1     
  Misses      173    173           
Impacted Files Coverage Δ
source/DSCResources/DSC_Computer/DSC_Computer.psm1 90% <100%> (-1%) ⬇️

Copy link
Member

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rcarpenter79)

@johlju johlju merged commit 9566942 into dsccommunity:main Jul 17, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DSC_Computer] Problem with Delete-ADSIObject
2 participants